Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)

a discussion (no related file):
please add a unit test that makes sure the output is nice-looking... i.e.

fn test_nice() {
    assert_eq!(format("{}", patricia_key!(7_u8)), "0x7");
}

src/transaction.rs line 649 at r1 (raw file):

    Clone,
    Default,
    Display,

why is this needed? it wraps a u128, this should be displayed fine

Code quote:

Display,

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

a discussion (no related file):

Done.

src/transaction.rs line 649 at r1 (raw file):

We talked about it later

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)

src/core.rs line 309 at r2 (raw file):

    Ord,
    derive_more:: Deref,
    Display,

why did this move down?

Code quote:

 Display,

src/core.rs line 311 at r2 (raw file):

    Display,
)]
#[display(fmt = "{}", "_0.to_fixed_hex_string()")]

this works? cool

Code quote:

#[display(fmt = "{}", "_0.to_fixed_hex_string()")]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

src/core.rs line 309 at r2 (raw file):

No special reason.

src/core.rs line 311 at r2 (raw file):

yes, its possible if u use the derive_moe:Display macro

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

src/core.rs line 309 at r2 (raw file):

please move back

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

src/core.rs line 309 at r2 (raw file):

I hope that I put it back to the same place

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)